Test mac os #53
Merged
Test mac os #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for MacOS in Github action Maybe see this to add test for FreeBSD : https://github.com/marketplace/actions/freebsd-vm
adding log to the test for better understanding
|
for the shellcheck fail do i add a ignore or do i remove the yellow color ? |
|
Hey @meo-pill, thx for the PR! You can remove the Yellow color for now, if we ever need it we can always add it back. Looks like the macOS build doesn't work yet, any idea why? |
refactor: add regularity to spaces (markusressel#52)
remove the yellow color that is unused in the test
the `"${variable,,}"` seam to not work on macOS so y remove it for the `skip_hardlink_flag` because it's always lowercase
remove all the lower-case casting
The command `lsattr` is not supported on macOS so I have remove it switch to `stat` instead of `ls` for better performance and no subshell use of parameter expansion with `%` in place of `awk` for performance and no subshell
|
Looks good! Is this PR ready for merging? |
|
Yes, for me it's ok to merge. Maybe add a FreeBSD test to github action, but that can be done on another PR
|
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the macOS test sequence fail a the first one so i think that a problème